-
Notifications
You must be signed in to change notification settings - Fork 20
Add lock around init func and prepare release #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes look good. I don't know why github actions are ignoring the hash comment and interpreting # 3.13
as a version number, but given that's the case, you should remove those lines from the ci.yml
.github/workflows/ci.yml
Outdated
3.10 | ||
3.11 | ||
3.12 | ||
# 3.13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you have to delete the line instead of trying to comment it out. The gha seem to read # 3.13
as a version tag in itself
3.10 | ||
3.11 | ||
3.12 | ||
# 3.13 leave out 3.13 due to a segfault |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also delete this
.github/workflows/ci.yml
Outdated
3.10 | ||
3.11 | ||
3.12 | ||
# 3.13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete this
I think this is ready for another review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #169