Add lock around init func and prepare release#170
Merged
lucianopaz merged 4 commits intopymc-devs:mainfrom Feb 18, 2025
Merged
Conversation
lucianopaz
requested changes
Feb 18, 2025
Member
lucianopaz
left a comment
lucianopaz
left a comment
There was a problem hiding this comment.
The code changes look good. I don't know why github actions are ignoring the hash comment and interpreting # 3.13 as a version number, but given that's the case, you should remove those lines from the ci.yml
.github/workflows/ci.yml
Outdated
| 3.10 | ||
| 3.11 | ||
| 3.12 | ||
| # 3.13 |
Member
There was a problem hiding this comment.
Looks like you have to delete the line instead of trying to comment it out. The gha seem to read # 3.13 as a version tag in itself
| 3.10 | ||
| 3.11 | ||
| 3.12 | ||
| # 3.13 leave out 3.13 due to a segfault |
.github/workflows/ci.yml
Outdated
| 3.10 | ||
| 3.11 | ||
| 3.12 | ||
| # 3.13 |
Member
Author
|
I think this is ready for another review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #169